Hi Marcel,
I disagree on it being hard to read. I agree, it doesn't read like a good book, or perhaps, some higher level languages, but in the main, I find it "not too bad" to read. Having said that, I get annoyed/confused/whatever with the use of really short labels what are pretty much like something out of the Armed Forces! I like to use meaningful names myself - ok, mostly - but I seem to remember TT likes the really short stuff. (As an example of what I find hard about his code.)
Anyway, as I said in my original post, it's probably me that's at fault.
EDIT: Yup, I just had a quick look in SMSQ 3.34 and it is the short names that wind me up about reading Tony's code. Told you it was me!
Cheers,
Norm.
SMSQ/E Source Reading
- NormanDunbar
- Forum Moderator
- Posts: 2278
- Joined: Tue Dec 14, 2010 9:04 am
- Location: Leeds, West Yorkshire, UK
- Contact:
Re: SMSQ/E Source Reading
Why do they put lightning conductors on churches?
Author of Arduino Software Internals
Author of Arduino Interrupts
No longer on Twitter, find me on https://mastodon.scot/@NormanDunbar.
Author of Arduino Software Internals
Author of Arduino Interrupts
No longer on Twitter, find me on https://mastodon.scot/@NormanDunbar.
- mk79
- QL Wafer Drive
- Posts: 1349
- Joined: Sun Feb 02, 2014 10:54 am
- Location: Esslingen/Germany
- Contact:
Re: SMSQ/E Source Reading
As somebody who has read, written and foremost debugged hundreds of thousands of lines of assembler I still disagreeNormanDunbar wrote:I disagree on it being hard to read. I agree, it doesn't read like a good book, or perhaps, some higher level languages, but in the main, I find it "not too bad" to read.
It's only a "relatively" recent development that assemblers processed more than 8 character per label (i.e. QMAC vs GST).Having said that, I get annoyed/confused/whatever with the use of really short labels what are pretty much like something out of the Armed Forces!
Marcel
Re: SMSQ/E Source Reading
With 230000 lines of code you need to keep labels short so as not to wear down your fingers.. To my mind, SMSQ/E's labels are neat and logical, and help to visualise the design! Labels that are so long you have to READ them, rather than just LOOK at and recognise them, are not sexy, IMHO, just messy and noisy.NormanDunbar wrote:EDIT: Yup, I just had a quick look in SMSQ 3.34 and it is the short names that wind me up about reading Tony's code. Told you it was me!
Per
dont be happy. worry
- ?
dont be happy. worry
- ?
Re: SMSQ/E Source Reading
mk79 wrote:Considering that there is no MDV driver in SMSQ/E I find this highly unlikelyDave wrote:Strip out the microdrive code and that leaves 12 lines
Looks like I'm keeping good company thenmk79 wrote:Your memory might be playing tricks here, MDV drivers were never part of SMSQ/E. Trust me on this, I happen to know that code.Derek Stewpot wrote:I am sure I used Super Gold Card with SMSQ/E and the microdrives worked. I think this was about version 2.76.